Conversation
cedric-cordenier
force-pushed
the
vault-batch-size
branch
from
0a629e6 to
1fa85b2
Compare
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
There was a problem hiding this comment.
Pull request overview
Updates CRE settings defaults to reduce the Vault OCR plugin batch size, likely to mitigate issues tracked in LINK-777.
Changes:
- Reduce
VaultPluginBatchSizeLimitdefault from 20 to 1 in the in-code schema defaults. - Update the TOML and JSON golden default files to match the new default value.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Changes the in-code default for VaultPluginBatchSizeLimit from 20 to 1. |
| pkg/settings/cresettings/defaults.toml | Updates the TOML default value for VaultPluginBatchSizeLimit to 1. |
| pkg/settings/cresettings/defaults.json | Updates the JSON default value for VaultPluginBatchSizeLimit to 1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -69,7 +69,11 @@ var Default = Schema{ | |||
| VaultIdentifierKeySizeLimit: Size(64 * config.Byte), | |||
There was a problem hiding this comment.
This changes a Vault OCR plugin default that the comment above flags as requiring a safe upgrade path (nodes may apply old/new defaults inconsistently during image upgrades). Please ensure deployments override VaultPluginBatchSizeLimit via the on-chain config (or another single source of truth) during rollout, and consider adding a short reference to LINK-777/upgrade notes near this default to prevent accidental unsafe changes later.
Approved, but it would be nice to add the rationale behind this PR? (I.e. why 20 is bad, and 1 is better) |
cedric-cordenier
force-pushed
the
vault-batch-size
branch
from
1fa85b2 to
084b694
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
📊 API Diff Results
|
cedric-cordenier
dismissed stale reviews from prashantkumar1982 and bolekk
via
2bff445
cedric-cordenier
force-pushed
the
vault-batch-size
branch
from
084b694 to
2bff445
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
Requires
Supports